Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] CVE-2023-6378 and CVE-2023-6481 fixes #1792

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

sejli
Copy link
Contributor

@sejli sejli commented Feb 6, 2024

Description

ktlint:0.45.0 contains problematic logback libraries, bumping ktlint to 0.47.1 and resolving the breaking linter changes. Duplicate of #1791

Issues Resolved

#1780 #1781

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sean Li <lnse@amazon.com>
@sejli sejli added security fix Security fix generated by WhiteSource backport 2.x backport 2.12 labels Feb 6, 2024
@joshuali925 joshuali925 merged commit 34f6490 into opensearch-project:main Feb 6, 2024
15 of 20 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1792-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34f64904519b0f2d57eb3587ccbd1e58dc9a3ebb
# Push it to GitHub
git push --set-upstream origin backport/backport-1792-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1792-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/observability/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/observability/backport-2.12
# Create a new branch
git switch --create backport/backport-1792-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34f64904519b0f2d57eb3587ccbd1e58dc9a3ebb
# Push it to GitHub
git push --set-upstream origin backport/backport-1792-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/observability/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-1792-to-2.12.

sejli added a commit to sejli/observability that referenced this pull request Feb 6, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 34f6490)
sejli added a commit to sejli/observability that referenced this pull request Feb 6, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 34f6490)
joshuali925 pushed a commit that referenced this pull request Feb 8, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 34f6490)
joshuali925 pushed a commit that referenced this pull request Feb 8, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 34f6490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.12 security fix Security fix generated by WhiteSource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants